Skip to content

Throw error when unable to compute file hash - #6954

Merged
Don Jayamanne (DonJayamanne) merged 1 commit into
microsoft:masterfrom
DonJayamanne:fsHash
Aug 13, 2019
Merged

Don Jayamanne (DonJayamanne) merged 1 commit into
microsoft:masterfrom
DonJayamanne:fsHash

Conversation

@DonJayamanne

Copy link
Copy Markdown

For #5926

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@DonJayamanne Don Jayamanne (DonJayamanne) added the no-changelog No news entry required label Aug 13, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 10ab7e7 into microsoft:master Aug 13, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants